gsk: Move GskRenderNode getters to internal API
authorEmmanuele Bassi <ebassi@gnome.org>
Wed, 24 Aug 2016 13:07:26 +0000 (14:07 +0100)
committerEmmanuele Bassi <ebassi@gnome.org>
Tue, 18 Oct 2016 10:49:15 +0000 (11:49 +0100)
GskRenderNode is, at its core, a write-only API; you're supposed to set
up the render nodes instead of querying them for state.

Querying render nodes is left to the GskRenderer implementation.

gsk/gskrendernode.c
gsk/gskrendernode.h
gsk/gskrendernodeprivate.h

index 63a1c371bee811a97b5a1b6d172eeb2c0b3c46b5..a2c0bb69827f3e082cd8a6bfe8c7ec6655af4323 100644 (file)
@@ -1287,7 +1287,7 @@ gsk_render_node_get_world_matrix (GskRenderNode     *node,
   *mv = node->world_matrix;
 }
 
-/**
+/*
  * gsk_render_node_get_scale_factor:
  * @node: a #GskRenderNode
  *
@@ -1296,8 +1296,6 @@ gsk_render_node_get_world_matrix (GskRenderNode     *node,
  * See also: gsk_renderer_get_scale_factor()
  *
  * Returns: the scale factor
- *
- * Since: 3.22
  */
 int
 gsk_render_node_get_scale_factor (GskRenderNode *node)
@@ -1353,15 +1351,13 @@ gsk_render_node_set_blend_mode (GskRenderNode *node,
   node->blend_mode = blend_mode;
 }
 
-/**
+/*
  * gsk_render_node_get_blend_mode:
  * @node: a #GskRenderNode
  *
  * Retrieves the blend mode set by gsk_render_node_set_blend_mode().
  *
  * Returns: the blend mode
- *
- * Since: 3.22
  */
 GskBlendMode
 gsk_render_node_get_blend_mode (GskRenderNode *node)
index 1aaa43ab5b04d7252cbc50a864d244afbf7a9893..7167be3fbd0c756a7742d9748f481c061bf4f2a4 100644 (file)
@@ -116,21 +116,14 @@ cairo_t *               gsk_render_node_get_draw_context        (GskRenderNode
 GDK_AVAILABLE_IN_3_22
 void                    gsk_render_node_set_blend_mode          (GskRenderNode *node,
                                                                  GskBlendMode   blend_mode);
-GDK_AVAILABLE_IN_3_22
-GskBlendMode            gsk_render_node_get_blend_mode          (GskRenderNode *node);
-
 GDK_AVAILABLE_IN_3_22
 void                    gsk_render_node_set_texture             (GskRenderNode *node,
                                                                  int            texture_id);
-
 GDK_AVAILABLE_IN_3_22
 void                    gsk_render_node_set_scaling_filter      (GskRenderNode *node,
                                                                  GskScalingFilter min_filter,
                                                                  GskScalingFilter mag_filter);
 
-GDK_AVAILABLE_IN_3_22
-int                     gsk_render_node_get_scale_factor        (GskRenderNode *node);
-
 GDK_AVAILABLE_IN_3_22
 void                    gsk_render_node_set_name                (GskRenderNode *node,
                                                                  const char    *name);
index 8077e73eeb5acc2c5b431cd33d8f36cef112ba74..5c0f4bd0cb853d1c774c25eed4797674c67b2095 100644 (file)
@@ -94,8 +94,12 @@ int gsk_render_node_get_texture (GskRenderNode *node);
 gboolean gsk_render_node_has_surface (GskRenderNode *node);
 gboolean gsk_render_node_has_texture (GskRenderNode *node);
 
+GskBlendMode gsk_render_node_get_blend_mode (GskRenderNode *node);
+
 GskRenderNode *gsk_render_node_get_toplevel (GskRenderNode *node);
 
+int gsk_render_node_get_scale_factor (GskRenderNode *node);
+
 void gsk_render_node_update_world_matrix (GskRenderNode *node,
                                           gboolean       force);